Re: [PATCH 2/2] perl/Makefile: install Git::I18N under NO_PERL_MAKEMAKER

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mar 11, 2012, 19:27 UTC
Message-ID: <CACBZZX47hAF_ayaa_QBrGcOkZ9UpR0Uxm-4Hf=FB685OKKvYFw@mail.gmail.com>
In-Reply-To: <7vfwdg16i8.fsf@alter.siamese.dyndns.org>

On Sat, Mar 10, 2012 at 22:38, Junio C Hamano <gitster@pobox.com> wrote:

Show 29 quoted lines

>>       echo '  $(RM) blib/lib/Git.pm; cp Git.pm blib/lib/' >> $@
>> +     echo '  $(RM) blib/lib/Git/I18N.pm; cp Git/I18N.pm blib/lib/Git/' >> $@
>>       echo '  $(RM) blib/lib/Error.pm' >> $@
>>       '$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \
>>       echo '  cp private-Error.pm blib/lib/Error.pm' >> $@
>>       echo install: >> $@
>>       echo '  mkdir -p "$$(DESTDIR)$(instdir_SQ)"' >> $@
>> +     echo '  mkdir -p "$$(DESTDIR)$(instdir_SQ)/Git"' >> $@
>>       echo '  $(RM) "$$(DESTDIR)$(instdir_SQ)/Git.pm"; cp Git.pm "$$(DESTDIR)$(instdir_SQ)"' >> $@
>> +     echo '  $(RM) "$$(DESTDIR)$(instdir_SQ)/Git/I18N.pm"; cp Git/I18N.pm "$$(DESTDIR)$(instdir_SQ)/Git"' >> $@
>>       echo '  $(RM) "$$(DESTDIR)$(instdir_SQ)/Error.pm"' >> $@
>>       '$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \
>>       echo '  cp private-Error.pm "$$(DESTDIR)$(instdir_SQ)/Error.pm"' >> $@
>>       echo instlibdir: >> $@
>>       echo '  echo $(instdir_SQ)' >> $@
>> +     echo '  echo $(instdir_SQ)/Git' >> $@
>
> This break "make NO_PERL_MAKEMAKER=Nah git-add--interactive", or
> anything that is a perl script, it appears.
>
> The resulting perl/perl.mak ends with
>
>        instlibdir:
>                echo foo
>                echo foo/Git
>
> but the top-level Makefile wants to see output from
>
>        make instlibdir

Fail, I just tested installing it to /tmp. Sorry about that.