Re: [PATCH 2/2] perl/Makefile: install Git::I18N under NO_PERL_MAKEMAKER

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 16, 2012, 16:14 UTC
Message-ID: <7v62e4ikv0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CACBZZX47hAF_ayaa_QBrGcOkZ9UpR0Uxm-4Hf=FB685OKKvYFw@mail.gmail.com>

This topic has been stuck for almost a week.

    * ab/perl-i18n (2012-03-10) 3 commits
     - fixup! de1e4ae
     - perl/Makefile: install Git::I18N under NO_PERL_MAKEMAKER
     - Git::I18N: compatibility with perl <5.8.3

I just ran (including the fixup patch queued at the tip) this:

    $ PATH=/usr/bin:/bin ;# I do not have any "git" in these two places
    $ export PATH
    $ make NO_PERL_MAKEMAKER=NoThanks prefix=/tmp/no-perl-makemaker
    $ make NO_PERL_MAKEMAKER=NoThanks prefix=/tmp/no-perl-makemaker install

    $ head -n 2 /tmp/no-perl-makemaker/libexec/git-core/git-difftool
    #!/usr/bin/perl
    use lib (split(/:/, $ENV{GITPERLLIB} || "/tmp/no-perl-makemaker/lib"));
    $ ls -l /tmp/no-perl-makemaker/lib
    total 44
    drwxrwxr-x 2 junio junio  4096 Mar 16 09:06 Git
    -rw-rw-r-- 1 junio junio 36222 Mar 16 09:06 Git.pm
    drwxrwxr-x 3 junio junio  4096 Mar 16 09:06 python2.6

And the resulting perl-ish Porcelain seems to work OK.

    $ PATH=$PATH:/tmp/no-perl-makemaker/bin
    $ git add -i

So I'll be merging this (after squashing the fix-up) to master.