Re: [PATCH v4 03/12] t/test-lib-functions.sh: allow to specify the tag name to test_commit
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- May 13, 2017, 17:41 UTC
- Message-ID
- <CACBZZX543mhEDEZ78KH=GU++u0Gq=YGt-WXye1nSC=EirRiO-g@mail.gmail.com>
- In-Reply-To
- <1360664260-11803-4-git-send-email-drafnel@gmail.com>
On Tue, Feb 12, 2013 at 11:17 AM, Brandon Casey <drafnel@gmail.com> wrote:
> The <message> part of test_commit() may not be appropriate for a tag name. > So let's allow test_commit to accept a fourth argument to specify the tag > name.
[Kind of late to notice, I know]
I see nobody spotted in four rounds of reviews that this commit didn't update the corresponding t/README docs for test_commit.
Show 42 quoted lines
> Signed-off-by: Brandon Casey <bcasey@nvidia.com>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> t/test-lib-functions.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> index fa62d01..61d0804 100644
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -135,12 +135,12 @@ test_pause () {
> fi
> }
>
> -# Call test_commit with the arguments "<message> [<file> [<contents>]]"
> +# Call test_commit with the arguments "<message> [<file> [<contents> [<tag>]]]"
> #
> # This will commit a file with the given contents and the given commit
> -# message. It will also add a tag with <message> as name.
> +# message, and tag the resulting commit with the given tag name.
> #
> -# Both <file> and <contents> default to <message>.
> +# <file>, <contents>, and <tag> all default to <message>.
>
> test_commit () {
> notick= &&
> @@ -168,7 +168,7 @@ test_commit () {
> test_tick
> fi &&
> git commit $signoff -m "$1" &&
> - git tag "$1"
> + git tag "${4:-$1}"
> }
>
> # Call test_merge with the arguments "<message> <commit>", where <commit>
> --
> 1.8.1.3.579.gd9af3b6
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html