Re: [PATCH v2] git-commit: populate the edit buffer with 2 blank lines before s-o-b
- From
Jeff King <peff@peff.net>
- Date
- Feb 22, 2013, 22:35 UTC
- Message-ID
- <20130222223513.GA21579@sigill.intra.peff.net>
- In-Reply-To
- <1361570727-20255-1-git-send-email-bcasey@nvidia.com>
On Fri, Feb 22, 2013 at 02:05:27PM -0800, Brandon Casey wrote:
Show 16 quoted lines
> From: Brandon Casey <drafnel@gmail.com> > > Before commit 33f2f9ab, 'commit -s' would populate the edit buffer with > a blank line before the Signed-off-by line. This provided a nice > hint to the user that something should be filled in. Let's restore that > behavior, but now let's ensure that the Signed-off-by line is preceded > by two blank lines to hint that something should be filled in, and that > a blank line should separate it from the Signed-off-by line. > > Plus, add a test for this behavior. > > Reported-by: John Keeping <john@keeping.me.uk> > Signed-off-by: Brandon Casey <drafnel@gmail.com> > --- > > How about something like this?
FWIW, as a casual reader of this series, I find this to be way easier to follow than the previous round.
-Peff