Re: [PATCH v4 05/12] sequencer.c: recognize "(cherry picked from ..." as part of s-o-b footer
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 12, 2013, 19:36 UTC
- Message-ID
- <7vtxphfhoq.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <511A98C0.70201@nvidia.com>
Brandon Casey <bcasey@nvidia.com> writes:
Show 11 quoted lines
>>> + return len > strlen(cherry_picked_prefix) + 1 && >>> + !prefixcmp(buf, cherry_picked_prefix) && buf[len - 1] == ')'; >>> +} >> >> Does the first "is it longer than the prefix?" check matter? If it >> is not, prefixcmp() would not match anyway, no? > > Probably not in practice, but technically we should only be accessing > len characters in buf even though buf may be longer than len. So the > check is just making sure the function doesn't access chars it's not > supposed to.
Sorry, I do not follow. Isn't caller's buf terminated with LF at buf[len], which would never match cherry_picked_prefix even if len is shorter than the prefix?