Re: [PATCH] you_still_use_that(): reword the instructions

From: Michael Montalbo <mmontalbo@gmail.com>
Date: Aug 26, 2026, 17:48 UTC
Message-ID: <CAC2QwmL6GvnLoW7xOc19vQ_Nj+0B=fiqAmz2sRnaev-boHyc3Q@mail.gmail.com>
In-Reply-To: <xmqqwltchj2p.fsf@gitster.g>

On Wed, Aug 26, 2026 at 10:45 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 24 quoted lines

>
> Michael Montalbo <mmontalbo@gmail.com> writes:
>
> > On Wed, Aug 26, 2026 at 10:00 AM Junio C Hamano <gitster@pobox.com> wrote:
> >>
> >> Michael Montalbo <mmontalbo@gmail.com> writes:
> >>
> >> > I think this change makes sense.
> >> >
> >> >> +                 "- Send an email to <git@vger.kernel.org> asking for help, only if\n"
> >> >> +                 "  suggestions by others do not work for you.\n"
> >> >
> >> > Maybe a slight reword to reinforce the idea that the command is not coming
> >> > back:
> >> >
> >> >   "Send an email... asking for help, only if suggested replacements
> >> >     for the [now?] deprecated command do not work for you."
> >> ...
> > Adding something like "[now] deprecated" or otherwise more explicitly
> > suggesting the command does not intend to return is my main feedback.
>
> The same function emits a message that says "this command is
> nominated for removal."  Perhaps we want to strengthen that part by
> saying "will be removed" instead?

Yes, saying it "will be removed" sounds great to me.