Re: [PATCH] you_still_use_that(): reword the instructions
- From
Michael Montalbo <mmontalbo@gmail.com>
- Date
- Aug 26, 2026, 17:12 UTC
- Message-ID
- <CAC2Qwm+Dx1UxLO3EOkQ-9uBokxacVfgrs7+XCj3BeM9vt8HcPw@mail.gmail.com>
- In-Reply-To
- <xmqqik4wizqf.fsf@gitster.g>
On Wed, Aug 26, 2026 at 10:00 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 26 quoted lines
> > Michael Montalbo <mmontalbo@gmail.com> writes: > > > I think this change makes sense. > > > >> + "- Send an email to <git@vger.kernel.org> asking for help, only if\n" > >> + " suggestions by others do not work for you.\n" > > > > Maybe a slight reword to reinforce the idea that the command is not coming > > back: > > > > "Send an email... asking for help, only if suggested replacements > > for the [now?] deprecated command do not work for you." > > > > Other than that suggestion, I think the change looks good. > > Not repeating 'replacement' there was deliberate for two reasons. > First, the preceding instruction mentions others suggesting > replacements, presenting an obvious opportunity to keep the wording > concise. Second, this message is meant to be generic. For a case > like 'whatschanged', the "new workflow" is to use another command > (i.e., 'replacement'), but other cases may involve doing things > differently and are not limited to a simple replacement with another > command. > > And that is why the message only says "suggestions by others".
Got it, the reasoning for removing 'replacement' makes sense. Thank you.
Adding something like "[now] deprecated" or otherwise more explicitly suggesting the command does not intend to return is my main feedback.