Re: [PATCH] you_still_use_that(): reword the instructions
- From
Michael Montalbo <mmontalbo@gmail.com>
- Date
- Aug 26, 2026, 16:06 UTC
- Message-ID
- <CAC2Qwm+Gg3nhxtwhQjrvrk6Pm_R=XEpAwYxVKqT0Ps9UZ-DAyg@mail.gmail.com>
- In-Reply-To
- <xmqqo6epj6is.fsf@gitster.g>
On Wed, Aug 26, 2026 at 7:33 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 20 quoted lines
>
> diff --git c/usage.c w/usage.c
> index 3f0118ab2a..9933b9911c 100644
> --- c/usage.c
> +++ w/usage.c
> @@ -392,15 +392,13 @@ NORETURN void you_still_use_that(const char *command_name, const char *hint)
> fputs(hint, stderr);
>
> fprintf(stderr,
> - _("If you still use this command, here's what you can do:\n"
> + _("If you need a replacement:\n"
> "\n"
> - "- read https://git-scm.com/docs/BreakingChanges.html\n"
> - "- check if anyone has discussed this on the mailing\n"
> - " list and if they came up with something that can\n"
> - " help you: https://lore.kernel.org/git/?q=%s\n"
> - "- send an email to <git@vger.kernel.org> to let us\n"
> - " know that you still use this command and were unable\n"
> - " to determine a suitable replacement\n"
> + "- Read https://git-scm.com/docs/BreakingChanges.html.\n\n"I noticed there are now two newlines at the end instead of one like before. Same for the lore link below. Is that intentional?
Show 8 quoted lines
> + "- Check what others on the mailing suggest as a replacement:\n" > + " https://lore.kernel.org/git/?q=%s\n\n" > + "- Send an email to <git@vger.kernel.org> asking for help, only if\n" > + " suggestions by others do not work for you.\n" > "\n"), > percent_encoded.buf); > strbuf_release(&percent_encoded); >