git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/apply.c: use iswspace() to detect line-ending-like chars

From
George Papanikolaou <g3orge.app@gmail.com>
Date
Mar 26, 2014, 16:58 UTC
Message-ID
<CAByyCQBX+xfDdMwFOE2bZg8W2S0jwj2nLV36JwH1N3D4Fn2BUw@mail.gmail.com>
In-Reply-To
<7vd2haq3n5.fsf@alter.siamese.dyndns.org>
On Tue, Mar 25, 2014 at 6:54 AM, Junio C Hamano <gitster@pobox.com> wrote:
> As a tangent, I have a suspicion that the current implementation may
> be wrong at the beginning of the string.  Wouldn't it match " abc"
> and "abc", even though these two strings shouldn't match?
Wouldn't that be accomplished by just removing the leading whitespace check?

I'm somewhat confused about what the function should match. I haven't grasped it.

-- papanikge's surrogate email. I may reply back. http://www.5slingshots.com/

Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 9 in “builtin/apply.c: use iswspace() to detect line-ending-like chars”
  1. builtin/apply.c: use iswspace() to detect line-ending-like charsGeorge Papanikolaou, Mar 20, 2014
  2. Eric SunshineMar 21, 2014
  3. Michael HaggertyMar 21, 2014
  4. Junio C HamanoMar 25, 2014
  5. George PapanikolaouMar 26, 2014
  6. Junio C HamanoMar 26, 2014
  7. Eric SunshineMar 21, 2014
  8. George PapanikolaouMar 22, 2014
  9. Eric SunshineMar 23, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.