From: George Papanikolaou <g3orge.app@gmail.com>
Date: Wed, 26 Mar 2014 16:58:19 GMT
Subject: Re: [PATCH] builtin/apply.c: use iswspace() to detect line-ending-like chars
Message-ID: <CAByyCQBX+xfDdMwFOE2bZg8W2S0jwj2nLV36JwH1N3D4Fn2BUw@mail.gmail.com>
In-Reply-To: <7vd2haq3n5.fsf@alter.siamese.dyndns.org>

On Tue, Mar 25, 2014 at 6:54 AM, Junio C Hamano <gitster@pobox.com> wrote:
> As a tangent, I have a suspicion that the current implementation may
> be wrong at the beginning of the string.  Wouldn't it match " abc"
> and "abc", even though these two strings shouldn't match?

Wouldn't that be accomplished by just removing the leading whitespace check?

I'm somewhat confused about what the function should match. I haven't
grasped it.

--
papanikge's surrogate email.
I may reply back.
http://www.5slingshots.com/