Re: [PATCH] builtin/apply.c: use iswspace() to detect line-ending-like chars
On 03/20/2014 08:39 PM, George Papanikolaou wrote:
Show 32 quoted lines
> Removing the bloat of checking for both '\r' and '\n' with the prettier
> iswspace() function which checks for other characters as well. (read: \f \t \v)
> ---
>
> This is one more try to clean up this fuzzy_matchlines() function as part of a
> microproject for GSOC. The rest more clarrified microprojects were taken.
> I'm obviously planning on applying.
>
> Thanks
>
> Signed-of-by: George 'papanikge' Papanikolaou <g3orge.app@gmail.com>
>
> builtin/apply.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/apply.c b/builtin/apply.c
> index b0d0986..912a53a 100644
> --- a/builtin/apply.c
> +++ b/builtin/apply.c
> @@ -295,9 +295,9 @@ static int fuzzy_matchlines(const char *s1, size_t n1,
> int result = 0;
>
> /* ignore line endings */
> - while ((*last1 == '\r') || (*last1 == '\n'))
> + while (iswspace(*last1))
> last1--;
> - while ((*last2 == '\r') || (*last2 == '\n'))
> + while (iswspace(*last2))
> last2--;
>
> /* skip leading whitespace */
>
In addition to Eric's comments...
What happens if the string consists *only* of whitespace?
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/