Re: [PATCH] Replace git-cvsimport with a rewrite that fixes major bugs.

From: Thomas Berg <merlin66b@gmail.com>
Date: Jan 2, 2013, 16:48 UTC
Message-ID: <CABYiQpkLze8aBZecGovBdMbxSE=kYH__KZntQDt7KwqUadUYdg@mail.gmail.com>
In-Reply-To: <20130102164107.GA19006@thyrsus.com>

On Wed, Jan 2, 2013 at 5:41 PM, Eric S. Raymond <esr@thyrsus.com> wrote:

Show 6 quoted lines

> Martin Langhoff <martin.langhoff@gmail.com>:
>> Replacement with something more solid is welcome, but until you are
>> extremely confident of its handling of legacy setups... I would still
>> provide the old cvsimport, perhaps in contrib.
>
> I am extremely confident.  I built a test suite so I could be.

I too am glad to see some work go into the cvsimport script. So just to clear things up, previously you said this:

> Yes, they must install an updated cvsps.

This is the problem, and one that is easily "solved" by just keeping a copy of the old command.

Remember that for many users of these tools it doesn't matter if the history is correct or not, as long as the head checkout contains the right files and they are able to submit new changes. With this definition of "works" git-cvsimport is not that broken I think.

Cheers,
- Thomas