Re: [PATCH] Replace git-cvsimport with a rewrite that fixes major bugs.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 3, 2013, 07:08 UTC
- Message-ID
- <7vmwwqyc8w.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CAEUsAPYwinmbDkSVu71WJRgUjLfBeNdKDFt6O1f8-Ti9evn6Hw@mail.gmail.com>
Chris Rorvick <chris@rorvick.com> writes:
> outdir needs to be quoted in the formatted string, i.e.: > > "%s | (cd '%s' >/dev/null ..."
The issue is real, but I am afraid that the above is not sufficient because outdir can contain single quotes. I think other places that call out to external processes share the same issue of being careless about quoting in general.
Doesn't Python come with a standard subprocess module that lets you spawn external programs safely, similar to the way Perl's list form open(), e.g. "open($fh, "-|", 'git', @args)", works?