Re: [PATCH v2] Ignore dirty submodule states during stash
- From
Vasily Titskiy <qehgt0@gmail.com>
- Date
- May 17, 2016, 17:12 UTC
- Message-ID
- <CABSveYjmqrPY4OVrYnWeCrjAqZdqOaciCzQ2_soB4akOcQgZpQ@mail.gmail.com>
- In-Reply-To
- <xmqqa8joy5sv.fsf@gitster.mtv.corp.google.com>
The command does nothing, so it's not needed. There is also a typo in my patch description, so I'll resend it again with needed changes. -- Regards, Vasily Titskiy
On Tue, May 17, 2016 at 1:04 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 12 quoted lines
> Vasily Titskiy <qehgt0@gmail.com> writes: > >> You're right, it's redundant here. Should I resubmit the path without this line? > > I wasn't pointing out that it was not needed. I was only asking > what it was meant to do. > > If you now think it shouldn't have been there, that merely means > your code was wrong. It does not mean I'm right ;-) > > With that line removed, would the patch now becomes right? Are > there other bugs?