Re: [PATCH v2 6/8] dir: fix checks on common prefix directory
- From
Elijah Newren <newren@gmail.com>
- Date
- Dec 16, 2019, 22:39 UTC
- Message-ID
- <CABPp-BHETKt1rTT76u9phGqjN+RU6B-ydzM=S0tzE6To_N4PQw@mail.gmail.com>
- In-Reply-To
- <xmqqzhfshsk2.fsf@gitster-ct.c.googlers.com>
On Mon, Dec 16, 2019 at 1:25 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
> > Elijah Newren <newren@gmail.com> writes: > > > Any bright ideas about what to do here? > > Restructuring the code so that we do not use "struct dirent" in the > first place, even in the original code that used only those obtained > from readdir(), perhaps? Then the codepath that would take the _thing_ > that describes the diretory entry would expect to see the data in > the struct you define (not "struct dirent" from the system), and you > can safely manufacture ones out of thin air.
Okay, I'll submit a new series dropping most the patches, but note this thread in the commit message of the new testcases in case someone (maybe my future self?) wants to dig further.