From: Elijah Newren Date: Mon, 16 Dec 2019 22:39:34 GMT Subject: Re: [PATCH v2 6/8] dir: fix checks on common prefix directory Message-ID: In-Reply-To: On Mon, Dec 16, 2019 at 1:25 PM Junio C Hamano wrote: > > Elijah Newren writes: > > > Any bright ideas about what to do here? > > Restructuring the code so that we do not use "struct dirent" in the > first place, even in the original code that used only those obtained > from readdir(), perhaps? Then the codepath that would take the _thing_ > that describes the diretory entry would expect to see the data in > the struct you define (not "struct dirent" from the system), and you > can safely manufacture ones out of thin air. Okay, I'll submit a new series dropping most the patches, but note this thread in the commit message of the new testcases in case someone (maybe my future self?) wants to dig further.