Re: [PATCH 2/8] Revert "dir.c: make 'git-status --ignored' work within leading directories"
- From
Elijah Newren <newren@gmail.com>
- Date
- Dec 9, 2019, 21:51 UTC
- Message-ID
- <CABPp-BGdUjQ8gg-VH+udmwBmW-cfhiE7wX=qkQ2jnCgS6eQJiw@mail.gmail.com>
- In-Reply-To
- <20191209213246.GA41680@generichostname>
On Mon, Dec 9, 2019 at 1:32 PM Denton Liu <liu.denton@gmail.com> wrote:
Show 23 quoted lines
> > Hi Elijah, > > On Mon, Dec 09, 2019 at 08:47:39PM +0000, Elijah Newren via GitGitGadget wrote: > > diff --git a/t/t7061-wtstatus-ignore.sh b/t/t7061-wtstatus-ignore.sh > > index 0c394cf995..ded7f97181 100755 > > --- a/t/t7061-wtstatus-ignore.sh > > +++ b/t/t7061-wtstatus-ignore.sh > > @@ -43,11 +43,14 @@ test_expect_success 'status untracked directory with --ignored -u' ' > > test_cmp expected actual > > ' > > cat >expected <<\EOF > > -?? untracked/uncommitted > > +?? untracked/ > > !! untracked/ignored > > EOF > > > > -test_expect_success 'status prefixed untracked directory with --ignored' ' > > +test_expect_failure 'status of untracked directory with --ignored works with or without prefix' ' > > + git status --porcelain --ignored | grep untracked/ >actual && > > Can we break this pipe up into two invocations so that we don't have a > git command in the upstream of a pipe?
Sigh...yeah, I keep doing this. And I'll probably keep doing it if someone can't chainlint (or pipefail) it. I'll fix it up.