Re: [PATCH 06/30] directory rename detection: testcases to avoid taking detection too far

From: Elijah Newren <newren@gmail.com>
Date: Nov 14, 2017, 01:02 UTC
Message-ID: <CABPp-BH2eGzTMzHvF9TD9uw_n8k_kbgvSF-ct8B9HMJRFAr6Ug@mail.gmail.com>
In-Reply-To: <CAGZ79kYOW9+pP5ApKDHR2_VwPXyiLEEbbO0-3ka-SDCP6ryLPw@mail.gmail.com>

On Mon, Nov 13, 2017 at 3:25 PM, Stefan Beller <sbeller@google.com> wrote:

> On Fri, Nov 10, 2017 at 11:05 AM, Elijah Newren <newren@gmail.com> wrote:

Show 6 quoted lines

>> +# Testcase 3a, Avoid implicit rename if involved as source on other side
>> +#   (Related to testcases 1c and 1f)
>> +#   Commit A: z/{b,c,d}
>> +#   Commit B: z/{b,c,d} (no change)
>
> This could also be an unrelated change such as adding w/e?

Yes, precisely. Whenever I have a "no change" commit, the intent is that there may be unrelated changes involved, they've just been excluded from the testcase in order to make it minimal.

>> +#   Commit C: y/{b,c}, x/d
>> +#   Expected: y/{b,c}, x/d