Re: [PATCH 15/16] repack: introduce `--write-midx=incremental`
- From
Elijah Newren <newren@gmail.com>
- Date
- Apr 16, 2026, 22:53 UTC
- Message-ID
- <CABPp-BH-Wd5vwxHCx8BXJvCANxTzD=54DzB+YCME7bL+xnQG_g@mail.gmail.com>
- In-Reply-To
- <e8e22d7958d513c3b7d4165857392a19277df65e.1774820449.git.me@ttaylorr.com>
On Sun, Mar 29, 2026 at 2:41 PM Taylor Blau <me@ttaylorr.com> wrote:
Show 11 quoted lines
>
> + if (!strcmp(var, "repack.midxsplitfactor")) {
> + repack_ctx->midx_split_factor = git_config_int(var, value,
> + ctx->kvi);
> + return 0;
> + }
> + if (!strcmp(var, "repack.midxnewlayerthreshold")) {
> + repack_ctx->midx_new_layer_threshold = git_config_int(var, value,
> + ctx->kvi);
> + return 0;
> + }Should there be any sanity checking on appropriate values beyond is-an-integer, such as requiring midx_split_factor > 1 ?