Re: [PATCH v4 06/16] midx: support custom `--base` for incremental MIDX writes
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Jun 12, 2026, 18:18 UTC
- Message-ID
- <aixNXOxfPZnAVLgK@nand.local>
- In-Reply-To
- <xmqqqzmbj3mb.fsf@gitster.g>
On Fri, Jun 12, 2026 at 06:21:48AM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> SZEDER Gábor <szeder.dev@gmail.com> writes: > > >> + layer="$(git multi-pack-index write --bitmap --incremental \ > >> + --no-write-chain-file --base="$(nth_line 1 "$midx_chain")")" && > > > > There is no 'nth_line' helper function in this test script. > > Good eyes. It has been there in the file next door t5335 since > February, but not available here in t5334.
Good spotting indeed. Fortunately or unfortunately for us, pulling on this thread revealed a bit of a rabbit hole. Patches forthcoming..
Thanks, Taylor