From: Elijah Newren Date: Thu, 16 Apr 2026 22:53:28 GMT Subject: Re: [PATCH 15/16] repack: introduce `--write-midx=incremental` Message-ID: In-Reply-To: On Sun, Mar 29, 2026 at 2:41 PM Taylor Blau wrote: > > + if (!strcmp(var, "repack.midxsplitfactor")) { > + repack_ctx->midx_split_factor = git_config_int(var, value, > + ctx->kvi); > + return 0; > + } > + if (!strcmp(var, "repack.midxnewlayerthreshold")) { > + repack_ctx->midx_new_layer_threshold = git_config_int(var, value, > + ctx->kvi); > + return 0; > + } Should there be any sanity checking on appropriate values beyond is-an-integer, such as requiring midx_split_factor > 1 ?