Re: [PATCH v1 10/11] completion: support restore

From: Elijah Newren <newren@gmail.com>
Date: Mar 9, 2019, 19:16 UTC
Message-ID: <CABPp-BGbqYUMEK0V_m0i7dpFb38Mm3sS-h0Ut-GSdvsKEZzRQg@mail.gmail.com>
In-Reply-To: <20190308101655.9767-11-pclouds@gmail.com>

On Fri, Mar 8, 2019 at 2:17 AM Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

>
> Completion for restore is straightforward. We could still do better
> though by give the list of just tracked files instead of all present
> ones. But let's leave it for later.

s/give/giving/

I'm slightly worried that due to using --no-overlay mode by default in restore, having tab-completion include untracked files increases the risk of accidentally nuking the wrong file. restore is a destructive command anyway and should thus be used with care, so perhaps this isn't a big deal, but I thought I'd mention it.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.