Re: [PATCH v1 00/11] And new command "restore"

From: Elijah Newren <newren@gmail.com>
Date: Mar 11, 2019, 16:01 UTC
Message-ID: <CABPp-BEmqJ4MfKwW81X21yXjZpf35kzqb9KaFs1uuBsmZ47_LA@mail.gmail.com>
In-Reply-To: <CACsJy8BB1GAaBX=YcmNf1fLj5chc5hcvHLTwvzwJgvSWWKNFdQ@mail.gmail.com>

On Sun, Mar 10, 2019 at 4:19 AM Duy Nguyen <pclouds@gmail.com> wrote:

Show 14 quoted lines

>
> On Fri, Mar 8, 2019 at 5:17 PM Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> > - --index has a different meaning in git-apply. I don't have a good
> >   suggestion except "yeah we have two different worlds now, the old
> >   and the new one"
>
> I will rename --index to --staged to avoid this. It is already used as
> synonym for --cached in git-diff. I will also add --staged as synonym
> to "git rm" so that "git status" can consistently advise "git <verb>
> --staged" where verb is either restore or rm.
>
> Since option rename is a lot of work. If you think this is not a good
> move, raise it now, even if it's just "I don't like it, no reasons".
> --

Works for me, but this sounds like the kind of thing Junio might object to, so I'm curious about his input.