git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/5] fast-export/import: cleanups and translation

From
Elijah Newren <newren@gmail.com>
Date
Oct 31, 2025, 19:37 UTC
Message-ID
<CABPp-BG_PhbFOS-Tre249nzMyc5YGK1yHMVgo8XGMq7Y4LewWw@mail.gmail.com>
In-Reply-To
<20251030123332.3337684-1-christian.couder@gmail.com>

On Thu, Oct 30, 2025 at 5:33 AM Christian Couder <christian.couder@gmail.com> wrote:

Show 21 quoted lines
>
>
> Introduction
> ------------
>
> In a previous v2 patch series[1] that I sent last May, there were two
> preparatory cleanup patches[2][3] that have been dropped in the v3 and
> next versions. I think these two cleanup patches are worth resending
> in their own series though.
>
> While at cleaning things up, I realized that, when working in this
> area of the code, I have often been annoyed by the fact that few error
> and warning messages were marked for translation. So I decided to also
> address this here.
>
> So patches 1/5 and 2/5 are small code cleanups that are resent, while
> patches 3/5, 4/5 and 5/5 are about marking strings for translation.
>
> [1] https://lore.kernel.org/git/20250526103314.1542316-1-christian.couder@gmail.com/
> [2] https://lore.kernel.org/git/20250526103314.1542316-2-christian.couder@gmail.com/
> [3] https://lore.kernel.org/git/20250526103314.1542316-3-christian.couder@gmail.com/

These all look like simple sensible fixes to me. The only problem I found looking over the patch is that you undersell the benefits of one of the changes in the commit message, but that's not even really a problem.

Series looks good to me.
Previous: Junio C HamanoNext: Christian Couder
Message 21 of 22 in “fast-export/import: cleanups and translation”
  1. 0/5 fast-export/import: cleanups and translationChristian Couder, Oct 28, 2025
  2. 1/5 gpg-interface: simplify ssh fingerprint parsingChristian Couder, Oct 28, 2025
  3. Junio C HamanoOct 28, 2025
  4. 2/5 gpg-interface: use left shift to define GPG_VERIFY_*Christian Couder, Oct 28, 2025
  5. 3/5 fast-export: mark strings for translationChristian Couder, Oct 28, 2025
  6. Junio C HamanoOct 28, 2025
  7. Christian CouderOct 29, 2025
  8. Junio C HamanoOct 29, 2025
  9. Christian CouderOct 30, 2025
  10. 4/5 fast-import: mark strings for translationChristian Couder, Oct 28, 2025
  11. Junio C HamanoOct 28, 2025
  12. 5/5 gpg-interface: mark a string for translationChristian Couder, Oct 28, 2025
  13. 0/5 fast-export/import: cleanups and translationChristian Couder, Oct 30, 2025
  14. 1/5 gpg-interface: simplify ssh fingerprint parsingChristian Couder, Oct 30, 2025
  15. 2/5 gpg-interface: use left shift to define GPG_VERIFY_*Christian Couder, Oct 30, 2025
  16. 3/5 fast-export: mark strings for translationChristian Couder, Oct 30, 2025
  17. 4/5 fast-import: mark strings for translationChristian Couder, Oct 30, 2025
  18. Elijah NewrenOct 31, 2025
  19. 5/5 gpg-interface: mark a string for translationChristian Couder, Oct 30, 2025
  20. Junio C HamanoOct 30, 2025
  21. Elijah NewrenOct 31, 2025
  22. Christian CouderNov 1, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.