Re: [PATCH 3/5] fast-export: mark strings for translation

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 29, 2025, 14:29 UTC
Message-ID: <CAP8UFD3S1s3_p3m-ZzRO=B7nQwJvbYMBew8_MZWJwSJEm4oFTA@mail.gmail.com>
In-Reply-To: <xmqqv7jzdtvl.fsf@gitster.g>

On Tue, Oct 28, 2025 at 2:43 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

>
> Christian Couder <christian.couder@gmail.com> writes:
>
> > Some error or warning messages in "builtin/fast-export.c" are marked
> > for translation, but many are not.
> >
> > To be more consistent and provide a better experience to people using a
> > translated version, let's mark all the remaining error or warning
> > messages for translation.
>
> Makes sense.  Should we also downcase some Unknown and Unexpected?

I am fine with doing it as part of this series, but I wonder if it should be part of this patch or in a separate patch.

If it's in a separate patch, each patch might be easier to review independently, but a number of lines will be changed several times in this series. So not sure what's the best practice.

Thanks.