From: Elijah Newren Date: Fri, 31 Oct 2025 19:37:35 GMT Subject: Re: [PATCH v2 0/5] fast-export/import: cleanups and translation Message-ID: In-Reply-To: <20251030123332.3337684-1-christian.couder@gmail.com> On Thu, Oct 30, 2025 at 5:33 AM Christian Couder wrote: > > > Introduction > ------------ > > In a previous v2 patch series[1] that I sent last May, there were two > preparatory cleanup patches[2][3] that have been dropped in the v3 and > next versions. I think these two cleanup patches are worth resending > in their own series though. > > While at cleaning things up, I realized that, when working in this > area of the code, I have often been annoyed by the fact that few error > and warning messages were marked for translation. So I decided to also > address this here. > > So patches 1/5 and 2/5 are small code cleanups that are resent, while > patches 3/5, 4/5 and 5/5 are about marking strings for translation. > > [1] https://lore.kernel.org/git/20250526103314.1542316-1-christian.couder@gmail.com/ > [2] https://lore.kernel.org/git/20250526103314.1542316-2-christian.couder@gmail.com/ > [3] https://lore.kernel.org/git/20250526103314.1542316-3-christian.couder@gmail.com/ These all look like simple sensible fixes to me. The only problem I found looking over the patch is that you undersell the benefits of one of the changes in the commit message, but that's not even really a problem. Series looks good to me.