Re: [PATCH] serve: reject valueless promisor-remote capability
- From
Elijah Newren <newren@gmail.com>
- Date
- Aug 12, 2026, 21:27 UTC
- Message-ID
- <CABPp-BGKfojr8wbQdkSegm_bL5r0t51_+qc7k74JMoKp4MDw3g@mail.gmail.com>
- In-Reply-To
- <pull.2199.git.1786516783909.gitgitgadget@gmail.com>
On Tue, Aug 11, 2026 at 11:39 PM Elijah Newren via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 8 quoted lines
> > From: Elijah Newren <newren@gmail.com> > > d460267613da (Add 'promisor-remote' capability to protocol v2, > 2025-02-18) added a receive callback which passes the capability value > directly to mark_promisor_remotes_as_accepted(). However, a client can > send the capability name without an '=' or value, in which case > get_capability() supplies NULL and strbuf_split_str() dereferences it.
Oops, I previously forgot to CC Christian as the author of d460267613da. Doing that now.