From: Elijah Newren Date: Wed, 12 Aug 2026 21:27:43 GMT Subject: Re: [PATCH] serve: reject valueless promisor-remote capability Message-ID: In-Reply-To: On Tue, Aug 11, 2026 at 11:39 PM Elijah Newren via GitGitGadget wrote: > > From: Elijah Newren > > d460267613da (Add 'promisor-remote' capability to protocol v2, > 2025-02-18) added a receive callback which passes the capability value > directly to mark_promisor_remotes_as_accepted(). However, a client can > send the capability name without an '=' or value, in which case > get_capability() supplies NULL and strbuf_split_str() dereferences it. Oops, I previously forgot to CC Christian as the author of d460267613da. Doing that now.