git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] serve: reject valueless promisor-remote capability

From
Christian Couder <christian.couder@gmail.com>
Date
Aug 13, 2026, 15:27 UTC
Message-ID
<CAP8UFD0+iXC3VxWmuuuB7La-pP6hdz58tr6vaEJSKpXJ_4ZH2w@mail.gmail.com>
In-Reply-To
<pull.2199.git.1786516783909.gitgitgadget@gmail.com>

On Wed, Aug 12, 2026 at 8:42 AM Elijah Newren via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 8 quoted lines
>
> From: Elijah Newren <newren@gmail.com>
>
> d460267613da (Add 'promisor-remote' capability to protocol v2,
> 2025-02-18) added a receive callback which passes the capability value
> directly to mark_promisor_remotes_as_accepted(). However, a client can
> send the capability name without an '=' or value, in which case
> get_capability() supplies NULL and strbuf_split_str() dereferences it.

Yeah, the original code you mention used strbuf_split_str(), but since 68a746e9a8 (promisor-remote: use string_list_split() in mark_remotes_as_accepted(), 2025-09-08), string_list_split() is used instead. Anyway string_list_split() also crashes when a NULL is passed as its `const char *string` argument.

> Reject the missing argument before parsing it, and add a test covering
> this case.
Yeah, the fix and its test look right to me. Thanks.
Previous: Elijah Newren
Message 3 of 3 in “serve: reject valueless promisor-remote capability”
  1. serve: reject valueless promisor-remote capabilityElijah Newren via GitGitGadget, Aug 12, 2026
  2. Elijah NewrenAug 12, 2026
  3. Christian CouderAug 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.