git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t4126: this test does not pass SANITIZE_LEAK; quit claiming it does

From
Elijah Newren <newren@gmail.com>
Date
Jan 4, 2022, 01:48 UTC
Message-ID
<CABPp-BF9XpxE2wLgAzZe0CR3NAAw0R9im4HBBm=BgirpNZOpAA@mail.gmail.com>
In-Reply-To
<xmqqtuenkk4k.fsf@gitster.g>
On Sat, Jan 1, 2022 at 5:21 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
>
> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Elijah Newren <newren@gmail.com>
> >
> > Signed-off-by: Elijah Newren <newren@gmail.com>
> > ---
> >     t4126: this test does not pass SANITIZE_LEAK; quit claiming it does
>
> Is this continuation of [*1*]?
Ah, yes it is.
> I think it will go away when dee839a2 (format-patch: mark
> rev_info with UNLEAK, 2021-12-16) is merged.

Can we fast track that patch? The patch looks good to me. In general, though, I would think the simpler fix of just removing the TEST_PASSES_SANITIZE_LEAK=true would be safer and could be fast tracked.

I'm sorry I missed these potential problems cropping up when I reviewed the earlier series (which added these flags to a bunch of scripts). I just didn't foresee these consequences.

Previous: Junio C Hamano
Message 4 of 4 in “t4126: this test does not pass SANITIZE_LEAK; quit claiming it does”
  1. t4126: this test does not pass SANITIZE_LEAK; quit claiming it doesElijah Newren via GitGitGadget, Dec 31, 2021
  2. Johannes SchindelinJan 1, 2022
  3. Junio C HamanoJan 2, 2022
  4. Elijah NewrenJan 4, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.