Re: [PATCH] t4126: this test does not pass SANITIZE_LEAK; quit claiming it does
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 1, 2022, 23:17 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2201020012010.7076@tvgsbejvaqbjf.bet>
- In-Reply-To
- <pull.1177.git.git.1640927702745.gitgitgadget@gmail.com>
Hi Elijah,
On Fri, 31 Dec 2021, Elijah Newren via GitGitGadget wrote:
Show 10 quoted lines
> From: Elijah Newren <newren@gmail.com> > > Signed-off-by: Elijah Newren <newren@gmail.com> > --- > t4126: this test does not pass SANITIZE_LEAK; quit claiming it does > > My builds in several different topics keep running into this, and I'm > sure it's a false positive -- I didn't change anything affecting this > test. I've just been ignoring it and submitting anyway, and I suspect > others are too.
So that's what is causing this. Thank you for chasing it down, it has been on my TO-DO list e.g. due to https://github.com/git-for-windows/git/runs/4622790431?check_suite_focus=true#step:5:146
Given that it points to a leak in `cmd_format_patch()` (oh no, we're _LEAKING_ some _MEMORY_ in a built-in, how did that ever happen, we must free it before... *checks notes* ... wait, we're quitting immediately after this function anyway? </sarcasm>) I wonder whether the disruption caused by `linux-leaks` should really be considered worth the benefit.
Anyway. Thank you for the patch!
Ciao, Dscho