From: Elijah Newren <newren@gmail.com>
Date: Tue, 04 Jan 2022 01:48:07 GMT
Subject: Re: [PATCH] t4126: this test does not pass SANITIZE_LEAK; quit claiming it does
Message-ID: <CABPp-BF9XpxE2wLgAzZe0CR3NAAw0R9im4HBBm=BgirpNZOpAA@mail.gmail.com>
In-Reply-To: <xmqqtuenkk4k.fsf@gitster.g>

On Sat, Jan 1, 2022 at 5:21 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Elijah Newren <newren@gmail.com>
> >
> > Signed-off-by: Elijah Newren <newren@gmail.com>
> > ---
> >     t4126: this test does not pass SANITIZE_LEAK; quit claiming it does
>
> Is this continuation of [*1*]?

Ah, yes it is.

> I think it will go away when dee839a2 (format-patch: mark
> rev_info with UNLEAK, 2021-12-16) is merged.

Can we fast track that patch?  The patch looks good to me.  In
general, though, I would think the simpler fix of just removing the
TEST_PASSES_SANITIZE_LEAK=true would be safer and could be fast
tracked.

I'm sorry I missed these potential problems cropping up when I
reviewed the earlier series (which added these flags to a bunch of
scripts).  I just didn't foresee these consequences.