Re: [PATCH 1/8] t/helper: add 'test-tool bitmap write' subcommand
- From
Elijah Newren <newren@gmail.com>
- Date
- Apr 19, 2026, 00:24 UTC
- Message-ID
- <CABPp-BELG+poD67JCojze=bzYsWr0UvdXb2Vai=eEY=2CzaGCg@mail.gmail.com>
- In-Reply-To
- <d5ef6b959fd7c05c73bd33aa2b394558320aceac.1776124588.git.me@ttaylorr.com>
On Mon, Apr 13, 2026 at 4:56 PM Taylor Blau <me@ttaylorr.com> wrote: [...]
> + bitmap_writer_push_commit(&writer, c, false);
$ git grep -h -A 1 bitmap_writer_push_commit -- '*.h'
void bitmap_writer_push_commit(struct bitmap_writer *writer,
struct commit *commit, unsigned pseudo_merge);Not a big deal, but for consistency, would it make more sense to pass 0 for the third argument, or to change the function signature change to accept bool instead of unsigned?