Re: [PATCH v3 0/9] pack-bitmap: fix various pseudo-merge bugs
- From
Taylor Blau <me@ttaylorr.com>
- Date
- May 12, 2026, 01:46 UTC
- Message-ID
- <agKGh/zv8RF/E/uB@nand.local>
- In-Reply-To
- <xmqqse7xpftn.fsf@gitster.g>
On Tue, May 12, 2026 at 10:38:44AM +0900, Junio C Hamano wrote:
Show 16 quoted lines
> Taylor Blau <me@ttaylorr.com> writes: > > > [Note to the maintainer: this series has been rebased onto the current > > tip of master, which is 7760f83b597 (Merge branch > > 'jc/neuter-sideband-fixup', 2026-05-11) at the time of writing]. > > A note like this is very much appreciated, but please also state the > reason why the rebase was necessary. "Because the current tip of > 'master' has advanced" is not a good reason. "The previous > synthetic base was made by merging topic X and topic Y on > then-current 'master', but both have graduated" is a so-so ok > reason. "Because the updated implementation of this series uses > facilities that appeared in recent 'master' that come from topics A > and B, which the previous iteration did not use" and "Recent updates > to 'master' brings in conflicting changes from topic C" are > excellent reasons.
I think the reason here was "bad habit that I am trying to break" ;-).
(Joking aside, I usually rebase my series locally before sending to ensure they can still be merged in cleanly. I usually remember to toss that rebased version aside and send the non-rebased version, but clearly forgot to do so here. Sorry about that.)
Thanks for queueing regardless.
Thanks, Taylor