From: Elijah Newren Date: Sun, 19 Apr 2026 00:24:04 GMT Subject: Re: [PATCH 1/8] t/helper: add 'test-tool bitmap write' subcommand Message-ID: In-Reply-To: On Mon, Apr 13, 2026 at 4:56 PM Taylor Blau wrote: [...] > + bitmap_writer_push_commit(&writer, c, false); $ git grep -h -A 1 bitmap_writer_push_commit -- '*.h' void bitmap_writer_push_commit(struct bitmap_writer *writer, struct commit *commit, unsigned pseudo_merge); Not a big deal, but for consistency, would it make more sense to pass 0 for the third argument, or to change the function signature change to accept bool instead of unsigned?