Re: [PATCH v3] contrib: add win32 credential-helper

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Aug 17, 2012, 11:50 UTC
Message-ID: <CABPQNSaBK=nyyW2bibTkQKFaihiyd8k_MHeUJRiBhA6tZ-XnFw@mail.gmail.com>
In-Reply-To: <7vtxw2w5s4.fsf@alter.siamese.dyndns.org>

On Fri, Aug 17, 2012 at 5:34 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 27 quoted lines

> Erik Faye-Lund <kusmabite@gmail.com> writes:
>
>> On Fri, Jul 27, 2012 at 7:10 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
>>> Since the Windows port of Git expects binary pipes, we need to make
>>> sure the helper-end also sets up binary pipes.
>>>
>>> Side-step CRLF-issue in test to make it pass.
>>>
>>> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
>>> ---
>>>
>>> Sorry for the delay, but here's the third iteration of my credential
>>> helper for Windows' credential API.
>>>
>>> The only change since v2 is that it now supports protocols without
>>> a host component, as suggested by Jeff King.
>>>
>>
>> ...aaand just as I sent it out, I realized that my Makefile was a bit
>> on the light side. Imagine this patch on top for now, please :)
>>
>
> I notice that I didn't queue either of these; are you still
> polishing them, or are they in good enough shape that it wouldn't
> make things harder for you if I queue it, with a plan to merge it
> soon after 1.7.12?
>

As far as I'm concerned, I consider this complete from my point of view. Should I send out a new version with the fixup squashed in?