Re: [PATCH v3] contrib: add win32 credential-helper
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Jul 27, 2012, 17:32 UTC
- Message-ID
- <CABPQNSZt0a+447qbr6j9ELHfsmfr03VUw6-efAiu0vLicaKyEg@mail.gmail.com>
- In-Reply-To
- <1343409006-5056-1-git-send-email-kusmabite@gmail.com>
On Fri, Jul 27, 2012 at 7:10 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
Show 14 quoted lines
> Since the Windows port of Git expects binary pipes, we need to make > sure the helper-end also sets up binary pipes. > > Side-step CRLF-issue in test to make it pass. > > Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com> > --- > > Sorry for the delay, but here's the third iteration of my credential > helper for Windows' credential API. > > The only change since v2 is that it now supports protocols without > a host component, as suggested by Jeff King. >
...aaand just as I sent it out, I realized that my Makefile was a bit on the light side. Imagine this patch on top for now, please :)
diff --git a/contrib/credential/wincred/Makefile b/contrib/credential/wincred/Makefile index b4f098f..bad45ca 100644 --- a/contrib/credential/wincred/Makefile +++ b/contrib/credential/wincred/Makefile @@ -4,5 +4,11 @@ CC = gcc RM = rm -f CFLAGS = -O2 -Wall +-include ../../../config.mak.autogen +-include ../../../config.mak + git-credential-wincred.exe : git-credential-wincred.c $(LINK.c) $^ $(LOADLIBES) $(LDLIBS) -o $@ + +clean: + $(RM) git-credential-wincred.exe
-- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en