git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] contrib: add win32 credential-helper

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 17, 2012, 03:34 UTC
Message-ID
<7vtxw2w5s4.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CABPQNSZt0a+447qbr6j9ELHfsmfr03VUw6-efAiu0vLicaKyEg@mail.gmail.com>
Erik Faye-Lund <kusmabite@gmail.com> writes:
Show 36 quoted lines
> On Fri, Jul 27, 2012 at 7:10 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
>> Since the Windows port of Git expects binary pipes, we need to make
>> sure the helper-end also sets up binary pipes.
>>
>> Side-step CRLF-issue in test to make it pass.
>>
>> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
>> ---
>>
>> Sorry for the delay, but here's the third iteration of my credential
>> helper for Windows' credential API.
>>
>> The only change since v2 is that it now supports protocols without
>> a host component, as suggested by Jeff King.
>>
>
> ...aaand just as I sent it out, I realized that my Makefile was a bit
> on the light side. Imagine this patch on top for now, please :)
>
> diff --git a/contrib/credential/wincred/Makefile
> b/contrib/credential/wincred/Makefile
> index b4f098f..bad45ca 100644
> --- a/contrib/credential/wincred/Makefile
> +++ b/contrib/credential/wincred/Makefile
> @@ -4,5 +4,11 @@ CC = gcc
>  RM = rm -f
>  CFLAGS = -O2 -Wall
>
> +-include ../../../config.mak.autogen
> +-include ../../../config.mak
> +
>  git-credential-wincred.exe : git-credential-wincred.c
>  	$(LINK.c) $^ $(LOADLIBES) $(LDLIBS) -o $@
> +
> +clean:
> +	$(RM) git-credential-wincred.exe

I notice that I didn't queue either of these; are you still polishing them, or are they in good enough shape that it wouldn't make things harder for you if I queue it, with a plan to merge it soon after 1.7.12?

Previous: Erik Faye-LundNext: Erik Faye-Lund
Message 3 of 5 in “contrib: add win32 credential-helper”
  1. contrib: add win32 credential-helperErik Faye-Lund, Jul 27, 2012
  2. Erik Faye-LundJul 27, 2012
  3. Junio C HamanoAug 17, 2012
  4. Erik Faye-LundAug 17, 2012
  5. Junio C HamanoAug 17, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.