Re: [PATCH v2 3/4] wrapper: supply xsetenv and xputenv

From

Erik Faye-Lund <kusmabite@gmail.com>

Date

Dec 15, 2011, 18:25 UTC

Message-ID

<CABPQNSZVRfFk=Y6JnnDkvcbPwXgm1MMeevDyrjFF=D4ubGPaTg@mail.gmail.com>

In-Reply-To

<7vzketohvg.fsf@alter.siamese.dyndns.org>

On Thu, Dec 15, 2011 at 6:38 PM, Junio C Hamano <gitster@pobox.com> wrote:

> Erik Faye-Lund <kusmabite@gmail.com> writes:
>
>> +extern int xsetenv(const char *name, const char *val, int override);
>> +extern int xputenv(const char *string);
>
> Actually, putenv(3) takes "char *string".

Ah, thanks for spotting.

> I adjusted 3 & 4 locally before queuing, so there is no need for resend,
> and judging from the later part of the discussion, it seems that it may be
> better to use only the first two patches from this series after all.

Yeah, I agree; patch 1 and 2 are the only ones that makes sense.