git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/4] wrapper: supply xsetenv and xputenv

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Dec 14, 2011, 14:07 UTC
Message-ID
<1323871631-2872-4-git-send-email-kusmabite@gmail.com>
In-Reply-To
<1323871631-2872-1-git-send-email-kusmabite@gmail.com>
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
 git-compat-util.h |    2 ++
 wrapper.c         |   14 ++++++++++++++
 2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index 77062ed..ab17d53 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -439,6 +439,8 @@ extern int xdup(int fd);
 extern FILE *xfdopen(int fd, const char *mode);
 extern int xmkstemp(char *template);
 extern int xmkstemp_mode(char *template, int mode);
+extern int xsetenv(const char *name, const char *val, int override);
+extern int xputenv(const char *string);
 extern int odb_mkstemp(char *template, size_t limit, const char *pattern);
 extern int odb_pack_keep(char *name, size_t namesz, unsigned char *sha1);
 
diff --git a/wrapper.c b/wrapper.c
index 85f09df..8d172ac 100644
--- a/wrapper.c
+++ b/wrapper.c
@@ -381,3 +381,17 @@ int remove_or_warn(unsigned int mode, const char *file)
 {
 	return S_ISGITLINK(mode) ? rmdir_or_warn(file) : unlink_or_warn(file);
 }
+
+int xsetenv(const char *name, const char *val, int overwrite)
+{
+	if (setenv(name, val, overwrite))
+		die_errno("setenv failed to set '%s' to '%s'", name, val);
+	return 0;
+}
+
+int xputenv(const char *string)
+{
+	if (putenv(string))
+		die_errno("putenv failed to set '%s' ", string);
+	return 0;
+}
-- 
1.7.7.1.msysgit.0.272.g9e47e
Previous: Erik Faye-LundNext: Junio C Hamano
Message 4 of 9 in “setenv/putenv errors”
  1. 0/4 setenv/putenv errorsErik Faye-Lund, Dec 14, 2011
  2. 1/4 compat/setenv.c: update errno when erroring outErik Faye-Lund, Dec 14, 2011
  3. 2/4 compat/setenv.c: error if name contains '='Erik Faye-Lund, Dec 14, 2011
  4. 3/4 wrapper: supply xsetenv and xputenvErik Faye-Lund, Dec 14, 2011
  5. Junio C HamanoDec 15, 2011
  6. Erik Faye-LundDec 15, 2011
  7. 4/4 use wrapper for unchecked setenv/putenv callsErik Faye-Lund, Dec 14, 2011
  8. Jeff KingDec 14, 2011
  9. Erik Faye-LundDec 15, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.