git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/4] setenv/putenv errors

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Dec 14, 2011, 14:07 UTC
Message-ID
<1323871631-2872-1-git-send-email-kusmabite@gmail.com>

Here's v2 of this series. It grew a bit since the last round, as I figured fixing the error-paths in compat/setenv.c made sense to do while I was at it, considering how Windows (which is one of the few likely platforms to be able to actually trigger this issue) use it.

Erik Faye-Lund (4):
  compat/setenv.c: update errno when erroring out
  compat/setenv.c: error if name contains '='
  wrapper: supply xsetenv and xputenv
  use wrapper for unchecked setenv/putenv calls
 builtin/clone.c      |    2 +-
 builtin/commit.c     |    6 +++---
 builtin/help.c       |    4 ++--
 builtin/init-db.c    |    2 +-
 builtin/merge.c      |    4 ++--
 builtin/notes.c      |    2 +-
 builtin/remote-ext.c |    4 ++--
 builtin/revert.c     |    2 +-
 compat/setenv.c      |   10 ++++++++--
 config.c             |    2 +-
 exec_cmd.c           |    4 ++--
 git-compat-util.h    |    2 ++
 git.c                |   18 +++++++++---------
 pager.c              |    2 +-
 run-command.c        |    2 +-
 setup.c              |    6 +++---
 wrapper.c            |   14 ++++++++++++++
 17 files changed, 54 insertions(+), 32 deletions(-)
-- 
1.7.7.1.msysgit.0.272.g9e47e
Next: Erik Faye-Lund
Message 1 of 9 in “setenv/putenv errors”
  1. 0/4 setenv/putenv errorsErik Faye-Lund, Dec 14, 2011
  2. 1/4 compat/setenv.c: update errno when erroring outErik Faye-Lund, Dec 14, 2011
  3. 2/4 compat/setenv.c: error if name contains '='Erik Faye-Lund, Dec 14, 2011
  4. 3/4 wrapper: supply xsetenv and xputenvErik Faye-Lund, Dec 14, 2011
  5. Junio C HamanoDec 15, 2011
  6. Erik Faye-LundDec 15, 2011
  7. 4/4 use wrapper for unchecked setenv/putenv callsErik Faye-Lund, Dec 14, 2011
  8. Jeff KingDec 14, 2011
  9. Erik Faye-LundDec 15, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.