git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 3/3] upload-archive: use start_command instead of fork

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Jul 7, 2011, 22:25 UTC
Message-ID
<CABPQNSYZqpfGwgQXqk4YFBXhSHTen1w7m2hwaF7YDsZmsaYY5Q@mail.gmail.com>
In-Reply-To
<20110707191528.GD12044@sigill.intra.peff.net>
On Thu, Jul 7, 2011 at 9:15 PM, Jeff King <peff@peff.net> wrote:
Show 8 quoted lines
> On Thu, Jul 07, 2011 at 01:43:09PM +0200, Erik Faye-Lund wrote:
>
>> The POSIX-function fork is not supported on Windows. Use our
>> start_command API instead.
>
> Is start_command the right solution? From my reading, the fork is
> actually because we want to set up a sideband multiplexer. Should we not
> just be using start_async() to start a thread, as we do in receive-pack?

I considered that, but discarded it because I figured it required me to plug through a file descriptor all the way through the code. But perhaps I was wrong, and dup2 will make that job a lot easier?

Previous: Jeff KingNext: Jeff King
Message 8 of 11 in “port upload-archive to windows”
  1. 0/3 port upload-archive to windowsErik Faye-Lund, Jul 7, 2011
  2. 1/3 compat/win32/sys/poll.c: upgrade from upstreamErik Faye-Lund, Jul 7, 2011
  3. 2/3 mingw: fix compilation of poll-emulationErik Faye-Lund, Jul 7, 2011
  4. 3/3 upload-archive: use start_command instead of forkErik Faye-Lund, Jul 7, 2011
  5. Johannes SixtJul 7, 2011
  6. Erik Faye-LundJul 7, 2011
  7. Jeff KingJul 7, 2011
  8. Erik Faye-LundJul 7, 2011
  9. Jeff KingJul 7, 2011
  10. Erik Faye-LundJul 7, 2011
  11. Jeff KingJul 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.