git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFC 2/3] mingw: fix compilation of poll-emulation

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Jul 7, 2011, 11:43 UTC
Message-ID
<1310038989-5724-3-git-send-email-kusmabite@gmail.com>
In-Reply-To
<1310038989-5724-1-git-send-email-kusmabite@gmail.com>

gnulib has changed the inclusion of poll.h from double quotes to single-quotes. But because compat/win32/sys/ isn't in our include-path, this breaks compilation. Change it back the way it was.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---

Ugh, I don't like this so much; this means that 1/3 is left in a broken state, which is a bit nasty for bisection. But this is the only way I can think of to show what are upstream-changes and what are git-specific.

An alternative is to move Windows' poll emulation out of the 'sys' folder, and enable the NO_SYS_POLL_H-switch for MinGW and MSVC builds.

I'm sure what best approach is. Input, anyone? :)
 compat/win32/sys/poll.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/compat/win32/sys/poll.c b/compat/win32/sys/poll.c
index 403eaa7..225ddce 100644
--- a/compat/win32/sys/poll.c
+++ b/compat/win32/sys/poll.c
@@ -29,7 +29,7 @@
 #include <sys/types.h>
 
 /* Specification.  */
-#include <poll.h>
+#include "poll.h"
 
 #include <errno.h>
 #include <limits.h>
-- 
1.7.6.135.ge14e3f
Previous: Erik Faye-LundNext: Erik Faye-Lund
Message 3 of 11 in “port upload-archive to windows”
  1. 0/3 port upload-archive to windowsErik Faye-Lund, Jul 7, 2011
  2. 1/3 compat/win32/sys/poll.c: upgrade from upstreamErik Faye-Lund, Jul 7, 2011
  3. 2/3 mingw: fix compilation of poll-emulationErik Faye-Lund, Jul 7, 2011
  4. 3/3 upload-archive: use start_command instead of forkErik Faye-Lund, Jul 7, 2011
  5. Johannes SixtJul 7, 2011
  6. Erik Faye-LundJul 7, 2011
  7. Jeff KingJul 7, 2011
  8. Erik Faye-LundJul 7, 2011
  9. Jeff KingJul 7, 2011
  10. Erik Faye-LundJul 7, 2011
  11. Jeff KingJul 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.