From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Thu, 07 Jul 2011 22:25:00 GMT
Subject: Re: [PATCH/RFC 3/3] upload-archive: use start_command instead of fork
Message-ID: <CABPQNSYZqpfGwgQXqk4YFBXhSHTen1w7m2hwaF7YDsZmsaYY5Q@mail.gmail.com>
In-Reply-To: <20110707191528.GD12044@sigill.intra.peff.net>

On Thu, Jul 7, 2011 at 9:15 PM, Jeff King <peff@peff.net> wrote:
> On Thu, Jul 07, 2011 at 01:43:09PM +0200, Erik Faye-Lund wrote:
>
>> The POSIX-function fork is not supported on Windows. Use our
>> start_command API instead.
>
> Is start_command the right solution? From my reading, the fork is
> actually because we want to set up a sideband multiplexer. Should we not
> just be using start_async() to start a thread, as we do in receive-pack?

I considered that, but discarded it because I figured it required me
to plug through a file descriptor all the way through the code. But
perhaps I was wrong, and dup2 will make that job a lot easier?