Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

From: Paolo Giarrusso <p.giarrusso@gmail.com>
Date: Oct 11, 2013, 09:32 UTC
Message-ID: <CAAcnjCRVUDYvBqB++AjTdY+9gBLECLsV+bbU9z5JJPS5=tG1rA@mail.gmail.com>
In-Reply-To: <20131009211101.GM9464@google.com>

On Wed, Oct 9, 2013 at 11:11 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 11 quoted lines

> Paolo Giarrusso wrote:
>
>> Seeing the email, I wonder whether there's hope something like that
>> can be preserved in an email, and whether the code should use some
>> escape sequence instead.
>
> Yes, please.  Mind if I amend it to
>
>         printf "%s\r" "$revcount/$revmax ($createcount)" >&2
>
> ?

Please do go ahead, by all means (arguably as a different commit, but those are minor details).

Show 10 quoted lines

> [...]
>>>         say()
>>>         {
>>>                 if [ -z "$quiet" ]; then
>>>                         echo "$@" >&2
>>>                fi
>>>         }
>
> I agree with the other reviewers that this should be fixed to use
> printf, too, but that's another topic.

Seconded.

-- 
Paolo G. Giarrusso - Ph.D. Student, Philipps-University Marburg
http://www.informatik.uni-marburg.de/~pgiarrusso/