[PATCH] git-subtree: Avoid using echo -n even indirectly
- From
Paolo G. Giarrusso <p.giarrusso@gmail.com>
- Date
- Oct 9, 2013, 03:57 UTC
- Message-ID
- <1381291045-98372-1-git-send-email-p.giarrusso@gmail.com>
Since say uses echo, this uses echo -n, which is not portable - see 19c3c5fdcb35b66b792534c5dc4e8d87a3952d2a.
Without this commit, the output looks like:
... -n 1891/ 1936 (1883) -n 1892/ 1936 (1884) -n 1893/ 1936 (1885) ...
Signed-off-by: Paolo G. Giarrusso <p.giarrusso@gmail.com> ---
Please CC me on replies, as I am not subscribed to this mailing list. I am tracking this submission via https://github.com/git/git/pull/61, which I'll duly close myself when the discussion is resolved.
contrib/subtree/git-subtree.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh index 7d7af03..ebfb78f 100755 --- a/contrib/subtree/git-subtree.sh +++ b/contrib/subtree/git-subtree.sh @@ -592,7 +592,9 @@ cmd_split() eval "$grl" | while read rev parents; do revcount=$(($revcount + 1)) - say -n "$revcount/$revmax ($createcount) " + if [ -z "$quiet" ]; then + printf "%s" "$revcount/$revmax ($createcount) " >&2 + fi debug "Processing commit: $rev" exists=$(cache_get $rev) if [ -n "$exists" ]; then
-- 1.8.4