git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Oct 9, 2013, 21:11 UTC
Message-ID
<20131009211101.GM9464@google.com>
In-Reply-To
<CAAcnjCQ+c=8wYZkqS7VzZ_bDDDkSwdQ3qdz77osrSpKDS9ON7Q@mail.gmail.com>
Paolo Giarrusso wrote:
> Seeing the email, I wonder whether there's hope something like that
> can be preserved in an email, and whether the code should use some
> escape sequence instead.
Yes, please.  Mind if I amend it to
	printf "%s\r" "$revcount/$revmax ($createcount)" >&2
?
[...]
Show 6 quoted lines
>>         say()
>>         {
>>                 if [ -z "$quiet" ]; then
>>                         echo "$@" >&2
>>                fi
>>         }

I agree with the other reviewers that this should be fixed to use printf, too, but that's another topic.

Thanks, Jonathan

Previous: Jeff KingNext: Paolo Giarrusso
Message 8 of 9 in “git-subtree: Avoid using echo -n even indirectly”
  1. git-subtree: Avoid using echo -n even indirectlyPaolo G. Giarrusso, Oct 9, 2013
  2. Tay Ray ChuanOct 9, 2013
  3. Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectlyPaolo Giarrusso, Oct 9, 2013
  4. Johannes SixtOct 9, 2013
  5. Matthieu MoyOct 9, 2013
  6. Paolo GiarrussoOct 9, 2013
  7. Jeff KingOct 9, 2013
  8. Jonathan NiederOct 9, 2013
  9. Paolo GiarrussoOct 11, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.