Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Oct 9, 2013, 21:11 UTC
- Message-ID
- <20131009211101.GM9464@google.com>
- In-Reply-To
- <CAAcnjCQ+c=8wYZkqS7VzZ_bDDDkSwdQ3qdz77osrSpKDS9ON7Q@mail.gmail.com>
Paolo Giarrusso wrote:
> Seeing the email, I wonder whether there's hope something like that > can be preserved in an email, and whether the code should use some > escape sequence instead.
Yes, please. Mind if I amend it to
printf "%s\r" "$revcount/$revmax ($createcount)" >&2
?
[...]
Show 6 quoted lines
>> say()
>> {
>> if [ -z "$quiet" ]; then
>> echo "$@" >&2
>> fi
>> }I agree with the other reviewers that this should be fixed to use printf, too, but that's another topic.
Thanks, Jonathan