git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/15] Make Gnome Credential helper more Gnome-y and support ancient distros

From
Brandon Casey <drafnel@gmail.com>
Date
Sep 23, 2013, 17:21 UTC
Message-ID
<CA+sFfMfhQ3ioMrppcTKaQ_0kMMjFuJ8mtv9iK+ixD8Ep0CFi4Q@mail.gmail.com>
In-Reply-To
<20130923102022.GA96514@yoda.local>
On Mon, Sep 23, 2013 at 3:20 AM, John Szakmeister <john@szakmeister.net> wrote:
Show 6 quoted lines
> On Sun, Sep 22, 2013 at 10:07:56PM -0700, Brandon Casey wrote:
>> A few cleanups, followed by improved usage of the glib library (no need
>> to reinvent the wheel when glib provides the necessary functionality), and
>> then the addition of support for RHEL 4.x and 5.x.
>>
>> Brandon Casey (15):
<snip>
Show 13 quoted lines
> I reviewed all of the commits in this series, and most are nice
> cleanups.  The only thing I'm a little shaky on is RHEL4
> support (patch 15).  In particular, this:
>
>     +/*
>     + * Just a guess to support RHEL 4.X.
>     + * Glib 2.8 was roughly Gnome 2.12 ?
>     + * Which was released with gnome-keyring 0.4.3 ??
>     + */
>
> Has that code been tested on RHEL4 at all?  I imagine it's hard
> to come by--it's pretty darn old--but it feels like a mistake to
> commit untested code.

The (poorly worded) comment is referring to the version of glib that is being tested by the pre-processor statements. Since gnome-keyring doesn't provide a way to test its version, and I'm not sure exactly which gnome release included gnome-keyring 0.4.3 or which glib version was distributed with which gnome version, I'm just roughly guessing based on dates and not-conclusive google searches that 2.8 is reasonable.

I'll try to clarify the wording here.
The code has been tested on CentOS 4.X.
> Otherwise, there are a few stylistic nits that I'd like to clean
> up.  Only one was introduced by you--Felipe pointed it out--and

Well, not exactly "introduced" by me, but I guess I can fix it in that same patch. :)

> I have a patch for the rest that I can submit after your series
> has been applied.
Sounds good.
> Acked-by: John Szakmeister <john@szakmeister.net>
-Brandon
Previous: John Szakmeister
Message 20 of 20 in “Make Gnome Credential helper more Gnome-y and support ancient distros”
  1. 00/15 Make Gnome Credential helper more Gnome-y and support ancient distrosBrandon Casey, Sep 23, 2013
  2. 01/15 contrib/git-credential-gnome-keyring.c: remove unnecessary pre-declarationsBrandon Casey, Sep 23, 2013
  3. 02/15 contrib/git-credential-gnome-keyring.c: remove unused die() functionBrandon Casey, Sep 23, 2013
  4. 03/15 contrib/git-credential-gnome-keyring.c: add static where applicableBrandon Casey, Sep 23, 2013
  5. 04/15 contrib/git-credential-gnome-keyring.c: exit non-zero when called incorrectlyBrandon Casey, Sep 23, 2013
  6. 05/15 contrib/git-credential-gnome-keyring.c: set Gnome application nameBrandon Casey, Sep 23, 2013
  7. 06/15 contrib/git-credential-gnome-keyring.c: strlen() returns size_t, not ssize_tBrandon Casey, Sep 23, 2013
  8. 07/15 contrib/git-credential-gnome-keyring.c: ensure buffer is non-empty before accessingBrandon Casey, Sep 23, 2013
  9. Felipe ContrerasSep 23, 2013
  10. Brandon CaseySep 23, 2013
  11. 08/15 contrib/git-credential-gnome-keyring.c: use gnome helpers in keyring_object()Brandon Casey, Sep 23, 2013
  12. 09/15 contrib/git-credential-gnome-keyring.c: use secure memory functions for passwdsBrandon Casey, Sep 23, 2013
  13. 10/15 contrib/git-credential-gnome-keyring.c: use secure memory for reading passwordsBrandon Casey, Sep 23, 2013
  14. 11/15 contrib/git-credential-gnome-keyring.c: use glib memory allocation functionsBrandon Casey, Sep 23, 2013
  15. 12/15 contrib/git-credential-gnome-keyring.c: use glib messaging functionsBrandon Casey, Sep 23, 2013
  16. 13/15 contrib/git-credential-gnome-keyring.c: report failure to store passwordBrandon Casey, Sep 23, 2013
  17. 14/15 contrib/git-credential-gnome-keyring.c: support ancient gnome-keyringBrandon Casey, Sep 23, 2013
  18. 15/15 contrib/git-credential-gnome-keyring.c: support really ancient gnome-keyringBrandon Casey, Sep 23, 2013
  19. John SzakmeisterSep 23, 2013
  20. Brandon CaseySep 23, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.