Re: [PATCH 00/15] Make Gnome Credential helper more Gnome-y and support ancient distros

From: John Szakmeister <john@szakmeister.net>
Date: Sep 23, 2013, 10:20 UTC
Message-ID: <20130923102022.GA96514@yoda.local>
In-Reply-To: <1379912891-12277-1-git-send-email-drafnel@gmail.com>

On Sun, Sep 22, 2013 at 10:07:56PM -0700, Brandon Casey wrote:

Show 30 quoted lines

> A few cleanups, followed by improved usage of the glib library (no need
> to reinvent the wheel when glib provides the necessary functionality), and
> then the addition of support for RHEL 4.x and 5.x.
> 
> Brandon Casey (15):
>   contrib/git-credential-gnome-keyring.c: remove unnecessary
>     pre-declarations
>   contrib/git-credential-gnome-keyring.c: remove unused die() function
>   contrib/git-credential-gnome-keyring.c: add static where applicable
>   contrib/git-credential-gnome-keyring.c: exit non-zero when called
>     incorrectly
>   contrib/git-credential-gnome-keyring.c: set Gnome application name
>   contrib/git-credential-gnome-keyring.c: strlen() returns size_t, not
>     ssize_t
>   contrib/git-credential-gnome-keyring.c: ensure buffer is non-empty
>     before accessing
>   contrib/git-credential-gnome-keyring.c: use gnome helpers in
>     keyring_object()
>   contrib/git-credential-gnome-keyring.c: use secure memory functions
>     for passwds
>   contrib/git-credential-gnome-keyring.c: use secure memory for reading
>     passwords
>   contrib/git-credential-gnome-keyring.c: use glib memory allocation
>     functions
>   contrib/git-credential-gnome-keyring.c: use glib messaging functions
>   contrib/git-credential-gnome-keyring.c: report failure to store
>     password
>   contrib/git-credential-gnome-keyring.c: support ancient gnome-keyring
>   contrib/git-credential-gnome-keyring.c: support really ancient
>     gnome-keyring

I reviewed all of the commits in this series, and most are nice cleanups. The only thing I'm a little shaky on is RHEL4 support (patch 15). In particular, this:

    +/*
    + * Just a guess to support RHEL 4.X.
    + * Glib 2.8 was roughly Gnome 2.12 ?
    + * Which was released with gnome-keyring 0.4.3 ??
    + */

Has that code been tested on RHEL4 at all? I imagine it's hard to come by--it's pretty darn old--but it feels like a mistake to commit untested code.

Otherwise, there are a few stylistic nits that I'd like to clean up. Only one was introduced by you--Felipe pointed it out--and I have a patch for the rest that I can submit after your series has been applied.

Acked-by: John Szakmeister <john@szakmeister.net>

-John