RE: [PATCH 07/15] contrib/git-credential-gnome-keyring.c: ensure buffer is non-empty before accessing

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sep 23, 2013, 05:43 UTC
Message-ID: <523fd4f6965ad_b79d67e786506@nysa.mail>
In-Reply-To: <1379912891-12277-8-git-send-email-drafnel@gmail.com>

Brandon Casey wrote:

Show 18 quoted lines

> Ensure buffer length is non-zero before attempting to access the last
> element.
> 
> Signed-off-by: Brandon Casey <drafnel@gmail.com>
> ---
>  contrib/credential/gnome-keyring/git-credential-gnome-keyring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
> index 1081224..8ae2eab 100644
> --- a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
> +++ b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
> @@ -315,7 +315,7 @@ static int credential_read(struct credential *c)
>  	{
>  		line_len = strlen(buf);
>  
> -		if(buf[line_len-1]=='\n')
> +		if(line_len && buf[line_len-1] == '\n')

The style is if ().

-- 
Felipe Contreras